Skip to content

Commit

Permalink
converted skipped test into scipy/numpy deprecation test (#560)
Browse files Browse the repository at this point in the history
  • Loading branch information
veenstrajelmer authored Oct 1, 2023
1 parent 90e601c commit 0d33b86
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions tests/test_external_packages.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,17 @@ def test_xugrid_opendataset_ugridplot():


@pytest.mark.systemtest
def SKIP_test_xugrid_opendataset_ugridplot_contourf():
def test_xugrid_opendataset_ugridplot_contourf_scipy_numpy_deprecation():
"""
this one fails with xarray>=2023.3.0: https://github.com/Deltares/xugrid/issues/117
This testcase gives DeprecationWarning with scipy<1.10.0: https://github.com/Deltares/dfm_tools/issues/557
It will fail if the function is actually deprecated
After fix, keep the testcase but rename and move to xugrid helpers, since it checks the contour/contourf plots
"""
file_nc = dfmt.data.fm_curvedbend_map(return_filepath=True)

uds = xu.open_dataset(file_nc,chunks={'time':1})
uds = xu.open_dataset(file_nc)

uds['mesh2d_flowelem_bl'].ugrid.plot.contourf()
uds['mesh2d_flowelem_bl'].ugrid.plot.contour()


@pytest.mark.unittest
Expand Down

0 comments on commit 0d33b86

Please sign in to comment.