Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cli extension #3

Merged
merged 22 commits into from
Mar 25, 2020
Merged

Feature/cli extension #3

merged 22 commits into from
Mar 25, 2020

Conversation

SiggyF
Copy link
Contributor

@SiggyF SiggyF commented Mar 9, 2020

Extend cli with new options

Copy link
Contributor Author

@SiggyF SiggyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments.

ddlpy/cli.py Outdated Show resolved Hide resolved
ddlpy/cli.py Outdated
@cli.command()
@click.argument('output', type=click.File('w'))
@click.option(
'--grootheid',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use English (grootheid -> quantity)

ddlpy/cli.py Outdated Show resolved Hide resolved
ddlpy/cli.py Outdated Show resolved Hide resolved
ddlpy/cli.py Outdated Show resolved Hide resolved
ddlpy/cli.py Show resolved Hide resolved
@anamabo anamabo merged commit 8748de9 into master Mar 25, 2020
@SiggyF SiggyF deleted the feature/cli-extension branch January 26, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants