correct mappings #7
Conversation
from_meshkernel_mesh2d_to_ugrid_mesh2d now also includes face_edges and edge_faces
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
ugrid/ugrid.py
Outdated
| elif system == "Darwin": | ||
| lib_path = Path(__file__).parent / "UGridApi.dylib" | ||
| lib_path = os.path.join(lib_path, "UGridApi.dylib") |
There was a problem hiding this comment.
Where is the macOS build config?
There was a problem hiding this comment.
now only windows is supported
ugrid/ugrid.py
Outdated
| elif system == "Linux": | ||
| lib_path = Path(__file__).parent / "UGridApi.so" | ||
| lib_path = os.path.join(lib_path, "UGridApi.so") |
There was a problem hiding this comment.
TC job can be made a bit nicer with subprojects.
ugrid/ugrid.py
Outdated
| system = platform.system() | ||
| lib_path = Path(__file__).parent | ||
| if system == "Windows": | ||
| lib_path = Path(__file__).parent / "UGridApi.dll" | ||
| lib_path = os.path.join(lib_path, "UGridApi.dll") | ||
| elif system == "Linux": | ||
| lib_path = Path(__file__).parent / "UGridApi.so" | ||
| lib_path = os.path.join(lib_path, "UGridApi.so") | ||
| elif system == "Darwin": | ||
| lib_path = Path(__file__).parent / "UGridApi.dylib" | ||
| lib_path = os.path.join(lib_path, "UGridApi.dylib") | ||
| else: | ||
| if not system: | ||
| system = "Unknown OS" | ||
| raise OSError(f"Unsupported operating system: {system}") |
There was a problem hiding this comment.
Can be moved to a free function.
There was a problem hiding this comment.
moved to a private function
tests/test_mesh2d.py
Outdated
There was a problem hiding this comment.
Shall we add a formatting action?
| if len(arr) == 0: | ||
| return None | ||
| return as_ctypes(arr) | ||
| if arr is not None and len(arr) > 0: |
There was a problem hiding this comment.
No, you get an error
|
Kudos, SonarCloud Quality Gate passed!
|
No description provided.