Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put level as the first column in basin.arrow #1971

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

visr
Copy link
Member

@visr visr commented Dec 12, 2024

The iMOD timeseries plugin shows the first column by default. That is storage. Most users want to view level first, and have to switch manually. So this simply puts level first, such that we get:

image

@evetion
Copy link
Member

evetion commented Dec 13, 2024

Changing our Julia structs and output formats so a plotter changes it defaults seems pretty backwards to me. Is changing the behavior of the iMOD plugin that hard?

@visr
Copy link
Member Author

visr commented Dec 13, 2024

No Julia struct has changed, it is only the order of the columns. And since level is used more I think it is actually desirable to have it more to the left, where it is less likely cut off the screen.

Probably changing the iMOD plugin isn't that hard, but there is currently no concept of default variable there, and I think this is actually an improvement.

@evetion
Copy link
Member

evetion commented Dec 14, 2024

No Julia struct has changed, it is only the order of the columns. And since level is used more I think it is actually desirable to have it more to the left, where it is less likely cut off the screen.

Probably changing the iMOD plugin isn't that hard, but there is currently no concept of default variable there, and I think this is actually an improvement.

Well a NamedTuple changed! 😅 That said, this is post-hoc reasoning, the goal is fixing the graph, and this is a bad way to do it. Please make at least an issue to make this configurable in the iMOD/Ribasim plugin before we merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants