Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cascading polders image in docs #1613

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Fix cascading polders image in docs #1613

merged 1 commit into from
Jul 8, 2024

Conversation

visr
Copy link
Member

@visr visr commented Jul 5, 2024

@Jingru923 I suggest this as an alternative to #1612. We try to keep this repository as small as possible and therefore prefer to not add images to it. So far we've uploaded images into #1 and used those. Recently GitHub changed something:

Uploading images here won't work anymore for displaying them in our docs, due to GitHub changes, see https://github.blog/changelog/2023-05-09-more-secure-private-attachments/

So using those directly in Markdown no longer seems to work (for newly uploaded images). But @evetion noticed that putting them in an img HTML tag works fine.

@Jingru923 Jingru923 self-requested a review July 8, 2024 07:12
@Jingru923
Copy link
Contributor

Looks good.

@Jingru923 Jingru923 merged commit df1ac9b into main Jul 8, 2024
24 checks passed
@Jingru923 Jingru923 deleted the img branch July 8, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants