Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine subnetwork shortage(supply)/excess(drainage) condition in timestep #79

Closed
gijsber opened this issue Mar 1, 2023 · 4 comments
Labels
allocation Allocation layer

Comments

@gijsber
Copy link
Contributor

gijsber commented Mar 1, 2023

Control actions may be different when you are in a shortage/supply state of an excess/discharge state.

A method is needed to determine on a subnetwork whether the system is for this subnetwork in a supply or drainage situation, such that proper controll settings can be triggered
part of #14. Links to #349

@gijsber gijsber added the physics Physical process representation label Mar 1, 2023
@gijsber gijsber added this to the Sprint 23.4 increment milestone Mar 1, 2023
@gijsber gijsber added this to Ribasim Mar 1, 2023
@gijsber gijsber moved this to 🔲 Todo in Ribasim Mar 1, 2023
@gijsber gijsber changed the title Determine areal shortage(supply)/excess(drainage) condition in timestep Determine subnetwork shortage(supply)/excess(drainage) condition in timestep Mar 1, 2023
@SnippenE SnippenE moved this from 🔲 Todo to 🏗 In progress in Ribasim May 1, 2023
@gijsber gijsber moved this from 🏗 In progress to 🔲 Todo in Ribasim May 2, 2023
@SnippenE SnippenE moved this from To do to Sprint backlog in Ribasim May 16, 2023
@SnippenE SnippenE moved this from Sprint backlog to To do in Ribasim May 16, 2023
@SnippenE SnippenE added the needs-refinement Issues that are too large and need refinement label May 17, 2023
@SnippenE SnippenE added allocation Allocation layer and removed physics Physical process representation labels Jun 5, 2023
@SnippenE SnippenE removed the needs-refinement Issues that are too large and need refinement label Jun 20, 2023
@SouthEndMusic SouthEndMusic moved this from To do to What's next in Ribasim Nov 23, 2023
@gijsber
Copy link
Contributor Author

gijsber commented Jan 18, 2024

from @SouthEndMusic
#79 is nog wel relevant in dat mijn huidige aanpak nog geen rekening houdt met supply vanuit een subnetwork. Ik zie nog niet direct voor me hoe dat kan worden toegevoegd, anders dan een soort iteratieve koppeling tussen hoofdnetwerk en subnetwerken, maar dat zou waarschijnlijk heel slecht zijn voor performance

@gijsber
Copy link
Contributor Author

gijsber commented Jan 18, 2024

Before calculating the main network allocation, you first do a subnetwork allocation. That calculation propagates demands to the sources. If that same calculation could be tweeked to calculate the outflow at the sinks without any water coming from the sources (ie the excess water which the subnetwork wants to dump on the main network), you might have the information you need

@SouthEndMusic
Copy link
Collaborator

Collecting subnetwork demand is added in #964. Currently an excess of water in a subnetwork is ignored as discussed with @gijsber; this yields zero demand from the subnetwork. The excess water in the subnetwork is not used anywhere else (e.g. in the main network or a different subnetwork via the main network), as this would complicate the allocation algorithm with more optimization problems for the exchanged water. Control as mentioned in the issue is covered by #714.

@github-project-automation github-project-automation bot moved this from What's next to ✅ Done in Ribasim Jan 31, 2024
@SouthEndMusic
Copy link
Collaborator

Before calculating the main network allocation, you first do a subnetwork allocation. That calculation propagates demands to the sources. If that same calculation could be tweeked to calculate the outflow at the sinks without any water coming from the sources (ie the excess water which the subnetwork wants to dump on the main network), you might have the information you need

@gijsber as discussed, we are currently not interested in using a surplus of water in a subnetwork. However, if at some point we would want to do this, I think it would look like this: do a last optimization after all priorities in a subnetwork, where connections from the subnetwork back to the main network have unlimited demand. This way this optimization is incentivized to bring as much of the surplus water back to the main network as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allocation Allocation layer
Projects
Archived in project
Development

No branches or pull requests

3 participants