Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests #4

Closed
gijsber opened this issue Sep 19, 2022 · 0 comments
Closed

Unit tests #4

gijsber opened this issue Sep 19, 2022 · 0 comments
Assignees
@AmyWilcox1
Labels
test Relates to unit testing

Comments

@gijsber
Copy link
Contributor

gijsber commented Sep 19, 2022

Add unit tests
@visr visr assigned AmyWilcox1 and unassigned visr Oct 24, 2022
@visr visr added the test Relates to unit testing label Oct 28, 2022
@visr visr added this to Ribasim Oct 28, 2022
@visr visr closed this as completed Nov 4, 2022
@visr visr moved this to Done in Ribasim Nov 4, 2022
SouthEndMusic added a commit that referenced this issue Dec 15, 2023
@visr @SouthEndMusic
Re-enable edge validation (#888)
641758f 
This validation was inadvertently not called anymore. This now adds a
test to make sure that doesn't happen again.

@SouthEndMusic tests fail since an invalid connection slipped in since,
do you want to take over this PR to fix that?

```
┌ Error: Cannot connect a basin to a basin.
│   edge_id = 0
│   id_src = #2
│   id_dst = #4
└ @ Ribasim D:\Ribasim\core\src\validation.jl:450
Error in testset "Allocation objective types" on worker 24444:
Error During Test at D:\Ribasim\core\test\allocation_test.jl:27
```

---------

Co-authored-by: Bart de Koning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AmyWilcox1 AmyWilcox1

Labels
test Relates to unit testing
Projects
Ribasim
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@visr @gijsber @AmyWilcox1