Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic Model validation in Ribasim python #245

Closed
SouthEndMusic opened this issue May 24, 2023 · 0 comments · Fixed by #250
Closed

Basic Model validation in Ribasim python #245

SouthEndMusic opened this issue May 24, 2023 · 0 comments · Fixed by #250
Assignees
@SouthEndMusic
Labels
python Relates to one of the Ribasim python packages

Comments

@SouthEndMusic
Copy link
Collaborator

SouthEndMusic commented May 24, 2023 •
edited
Loading

This is more basic than #200; when you instantiate objects in Python, some basic checks should be done on the validity of the input:

  • Node: passed node types are valid
  • Every node ID is used in exactly one node object

These are ones I noticed were missing but more could be helpful. Misspelling a node type made QGIS not display the node properly without throwing an error, and mistakes with the node IDs only come to light in the Julia core with errors with long tracebacks.
@github-project-automation github-project-automation bot moved this to To do in Ribasim May 24, 2023
@Hofer-Julian Hofer-Julian added the python Relates to one of the Ribasim python packages label May 24, 2023
@SouthEndMusic SouthEndMusic self-assigned this May 24, 2023
@SouthEndMusic SouthEndMusic moved this from To do to 🏗 In progress in Ribasim May 26, 2023
@SouthEndMusic SouthEndMusic mentioned this issue May 26, 2023
Merged
@Hofer-Julian Hofer-Julian mentioned this issue May 30, 2023
Closed
SouthEndMusic added a commit that referenced this issue May 31, 2023
@SouthEndMusic
Add python model validation (#250)
c410a7a 
Fixes #245.

---------

Co-authored-by: Bart de Koning <[email protected]>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Ribasim May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SouthEndMusic SouthEndMusic

Labels
python Relates to one of the Ribasim python packages
Projects
Ribasim
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add python model validation Deltares/Ribasim
2 participants
@Hofer-Julian @SouthEndMusic