-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Terminal / static
as it is not needed
#1209
Comments
Indeed in terms of information the Regarding the fact that you could run your model without this table: a quick search trough the core code showed that currently the terminal node data is only used in the corresponding In conclusion: I think indeed the |
Terminal / static
needed or not?
I would advise against removing the table, as it would break the current generic code patterns, for just a small gain in lines removed. I would argue it increases complexity. |
The table already doesn't appear in any of our test models. In the add API it becomes obvious. model.terminal.add(Node(14, Point(3.0, -2.0)))
model.terminal.add(Node(14, Point(3.0, -2.0)), [terminal.Static()]) |
Terminal / static
needed or not?Terminal / static
as it is not needed ?
Terminal / static
as it is not needed ?Terminal / static
as it is not needed
This also removes the Terminal type from the core, as it is not needed for the same reason. That meant I had to adapt a bit of code that relied on `getfield(p, :terminal)` working. Fixes #1209
When updating models in #1110 I noticed that I can run a model with a Terminal node with or without the 'Terminal / static' table. Then I realized, especially with the new API, there is no real information in that table that isn't already in the Node table. We should look into if that is true, and if it is, perhaps we should just remove
Terminal / static
.https://deltares.github.io/Ribasim/core/usage.html#sec-terminal
The text was updated successfully, but these errors were encountered: