Check geometry list input lengths #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillSenior
reviewed
Aug 7, 2023
meshkernel/py_structures.py
Outdated
Comment on lines
191
to
196
|
|
||
| if len(self.values) > 0 and len(self.values) != len(self.y_coordinates): | ||
| raise InputError( | ||
| "The length of values is not equal to the length of y_coordinates" | ||
| ) | ||
|
|
There was a problem hiding this comment.
I don't think this test is necessary.
line 182 checks that x_coords and y_coords are the same length, then
line 187 check values is same as x_coords (if length of values is > 0)
at this point it must be that x_coords and y_coords are the same size.
BillSenior
approved these changes
Aug 7, 2023
BillSenior
approved these changes
Aug 14, 2023
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #32