Convert constructor types in py structures #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…linearGrid constructor parameters to appropriate types in case the user does not specify the correct types When the user types are not convertible, asarray throws a ValueError exception
lucacarniato
changed the title
95 tasks
ahmad-el-sayed
requested changes
Jan 31, 2024
meshkernel/py_structures.py
Outdated
| @@ -421,18 +423,20 @@ def __init__( | |||
| check_front_collisions=0, | |||
| def test_contacts_invalid_input(): | ||
| """Test exceptions due to malformed input for Contacts""" | ||
| with pytest.raises(ValueError): | ||
| Contacts(mesh1d_indices=["0", "1", "abc"], mesh2d_indices=["0", "1", "2"]) |
There was a problem hiding this comment.
Please replace the silly string "abc" with something more meaningful, elegant and powerful. The string "nonna" is recommended.
tests/test_py_structures_inputs.py
Outdated
Comment on lines
501
to
512
| assert np.array_equal( | ||
| gridded_samples.x_coordinates, np.array([1.0, 2.0, 3.0], dtype=np.double) | ||
| ) | ||
| assert np.array_equal( | ||
| gridded_samples.y_coordinates, np.array([2.0, 3.0, 4.0], dtype=np.double) | ||
| ) | ||
| assert np.array_equal( | ||
| gridded_samples.values, | ||
| np.array( | ||
| [10.0, 20.0, 30.0, 40.0, 50.0, 60.0, 70.0, 80.0, 90.0, 100.0], | ||
| dtype=np.double, | ||
| ), |
There was a problem hiding this comment.
Optional: can use numpy.asarray
…convert_constructor_parameters
ahmad-el-sayed
approved these changes
Feb 19, 2024
lucacarniato
deleted the
feature/GRIDEDIT-846_convert_constructor_parameters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…linearGrid constructor parameters to appropriate types in case the user does not specify the correct types
When the user types are not convertible, asarray throws a ValueError exception