GRIDEDIT-680: render curvilinear grid #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasbuykx
force-pushed
the
feature/GRIDEDIT-680-render-curvilineargrid
branch
3 times, most recently
from
a5922ea to
00575be
Compare
andreasbuykx
force-pushed
the
feature/GRIDEDIT-680-render-curvilineargrid
branch
7 times, most recently
from
8671921 to
9a72af8
Compare
lucacarniato
approved these changes
Feb 19, 2024
The utility function uses the parameters as number of nodes instead of as number of cells.
This test fails because the utility generates node coordinates in a different order
… coordinates This commit fixes TestUtility_CreateCurvilinearGrid_EqualToMakeGridParameters, but causes the following 4 tests to fail: - CurvilinearDerefineThroughAPI - CurvilinearInsertFaceThroughAPI - CurvilinearLineMirrorThroughAPI - CurvilinearRefineThroughAPI
Temporarily change flip the dimensions to accomodate m,n indexing issue in meshkernel
andreasbuykx
force-pushed
the
feature/GRIDEDIT-680-render-curvilineargrid
branch
from
9a72af8 to
d9a2461
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a common interface for Mesh2D and CurvilinearMesh to access the nodes and edges.