Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meshkernel contacts in Network instance created from netfile #575

Closed
veenstrajelmer opened this issue Nov 1, 2023 · 0 comments · Fixed by #602
Closed

meshkernel contacts in Network instance created from netfile #575

veenstrajelmer opened this issue Nov 1, 2023 · 0 comments · Fixed by #602

Comments

@veenstrajelmer
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently, the contacts of the Network._link1d2d.link1d2d and the Network.link1d2d.meshkernel.contacts_get() are out of sync when reading a network file. The latter is empty, because the meshkernel contacts are not set upon reading the network. This is not implemented in meshkernel yet: Deltares/MeshKernelPy#107

Describe the solution you'd like
After implementation of contacts_set() in meshkernel we can use it in UgridReader.read_link1d2d(). If implemented there, the two contacts administrations should be in sync again and the assertions in test_create_1d_2d_1d2d can be uncommented. Also, the two plots should be the same (currently the second one misses the contacts).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant