Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libraries, merge changes into main, publish package #1

Merged
merged 12 commits into from
Apr 15, 2024

Conversation

philn-delphia
Copy link
Collaborator

@philn-delphia philn-delphia commented Apr 15, 2024

Forking the original trstringer/manual-approval so we can continue diverging and supporting changes. Thanks to the authors of this great workflow and everyone who's contributed.

There's a PR to merge the ability to leave approvers blank in the original repo. This PR includes that, along with some updates and minor changes.

  • Publish the container under ghcr.io/delphia/manual-approval
  • Update golang, packages and alpine
  • Allow approvers to be empty. When empty, issue creator will be assigned to the issue but anyone with repo access can approve.
  • Small fixes like rewording titles to be shorter and linking to the run correctly.

@philn-delphia philn-delphia self-assigned this Apr 15, 2024
Copy link

@samueldg samueldg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thanks for porting the changes here and the improvements along the way.

I like the idea of maintaining a "changelog" in the README that justifies the existence of this fork 👌

@philn-delphia philn-delphia merged commit 9f2b88b into main Apr 15, 2024
1 check failed
@philn-delphia philn-delphia deleted the switch-to-delphia-fork branch April 15, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants