Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve incorrect binary path for docker hub based images #86

Merged
merged 7 commits into from
Jan 25, 2023

Conversation

sheldonhull
Copy link
Contributor

@sheldonhull sheldonhull commented Jan 25, 2023

- see if this will help with the random disconnects
- Not necessarily better, but was more clear for the export and kubeconfig input, so I'm just flipping to that to see if it helps with workflow. Can toggle easily with kind if desired.
@sheldonhull
Copy link
Contributor Author

sheldonhull commented Jan 25, 2023

👉 Note, there are some integration test failures for json that is maintenance to improve and being tracked in AB#480669. Additionally some other scan info should be overriden as we aren't going to patch major kubernetes library versions at this time as it's breaking changes not normal patch level changes.

@sheldonhull sheldonhull added the bug Something isn't working label Jan 25, 2023
@sheldonhull
Copy link
Contributor Author

approving as the same test issue isn't related to this fix which is important to get out.

@sheldonhull sheldonhull merged commit 707a3d5 into main Jan 25, 2023
@sheldonhull sheldonhull deleted the refactor/use-minikube branch January 25, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest chart version image with problem
1 participant