Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QuickJS dependency #328

Closed
wants to merge 1 commit into from
Closed

Conversation

richarddd
Copy link
Contributor

Update QuickJS dependency.

@DelSkayn would you also consider switching to the https://github.com/quickjs-ng/ fork?

It's more actively maintained, has some great performance improvements and will eventually be merged with QuickJS.

I've started some work in a branch if you're interested.

@DelSkayn
Copy link
Owner

I was holding of on switching to quickjs-ng because they where going to be merged, I was under the impression that the original would become the base, so I didn't want to have to switch and then in the future switch back. But I am not sure about the timeline of the merge, so if it is still far out we could consider moving to quickjs-ng.

@richarddd
Copy link
Contributor Author

I was holding of on switching to quickjs-ng because they where going to be merged, I was under the impression that the original would become the base, so I didn't want to have to switch and then in the future switch back. But I am not sure about the timeline of the merge, so if it is still far out we could consider moving to quickjs-ng.

Charlie mentioned fall 24 here:
quickjs-ng/quickjs#374 (comment)

@richarddd
Copy link
Contributor Author

Somehow git checked out the wrong remote. So closing this PR and creating a new one instead!

@richarddd richarddd closed this Jul 10, 2024
@richarddd richarddd deleted the update-qjs branch July 10, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants