Store temp content per post, Fixes #84 #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walbo
reviewed
Apr 13, 2018
| @@ -441,7 +441,7 @@ public function append_modules_content( string $content ) : string { | |||
| * @return string | |||
| */ | |||
| private function get_modules_content( \WP_Post $post ) : string { | |||
| $flexible_content = $this->_flexible_content; | |||
| $flexible_content = $this->_flexible_content[ $post->ID ] ?? null; | |||
There was a problem hiding this comment.
Bør det ikke være ?? []?
Siden du har sagt at det er en array?
There was a problem hiding this comment.
Glem det. Jeg som tenkte feil
There was a problem hiding this comment.
Hmm, nei. $flexible_content (den lokale i funksjonen) skal ikke være array.
olethomas
approved these changes
Apr 13, 2018
walbo
approved these changes
Apr 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change core property
$_flexible_contentfrom string to array. Temporary save Hogan content per post id to avoid getting content for previous post in loop.See #84