Build/PHPCS: use PHPCompatibilityWP and minor ruleset tweak #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR:
* Switches the repo over to use `PHPCompatibilityWP` rather than `PHPCompatibility`.
As this repo and ruleset appears to be aimed at WordPress projects, using the `PHPCompatibilityWP` ruleset is the better choice to prevent false positives for PHP functions and constants which are back-filled by WP.
* Switches the dependency over to use the repo in the `PHPCompatibility` organisation rather than the one in `wimg`'s personal account.
### References:
* https://github.com/PHPCompatibility/PHPCompatibilityWP
* PHPCompatibility/PHPCompatibility#688
* https://github.com/PHPCompatibility/PHPCompatibility/releases/tag/8.2.0
Properties belong to individual sniffs, not to standards. The way the property was set, it was going to be ignored. This minor changes fixes that.
|
Hi @jrfnl. Thank you for the pull request! |
stian-overasen
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Summary
Build/PHPCS: use PHPCompatibilityWP
PHPCompatibilityWPrather thanPHPCompatibility.As this repo and ruleset appears to be aimed at WordPress projects, using the
PHPCompatibilityWPruleset is the better choice to prevent false positives for PHP functions and constants which are back-filled by WP.PHPCompatibilityorganisation rather than the one inwimg's personal account.References:
PHPCS Ruleset: minor fix
Properties belong to individual sniffs, not to standards. The way the property was set, it was going to be ignored. This minor changes fixes that.
References: