[chrome] Add DevTools Recorder

[nickserv]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: https://developer.chrome.com/docs/extensions/reference/devtools_recorder/

[typescript-bot]

@nickmccurdy Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• chrome — on npm, on unpkg

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ❌ Continuous integration tests have failed
• 🕐 Most recent commit is approved by type definition owners or DT maintainers

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 31 days — it is considered abandoned, and therefore closed!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 61891,
  "author": "nickmccurdy",
  "headCommitOid": "2a1797e4bbab0b709be586cf5223fe36c5959d27",
  "mergeBaseOid": "c696c6a733aeddf1c3211319ad3711d14e166311",
  "lastPushDate": "2022-08-23T16:26:41.000Z",
  "lastActivityDate": "2023-02-08T07:59:45.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "chrome",
      "kind": "edit",
      "files": [
        {
          "path": "types/chrome/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/chrome/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/chrome/test/index.ts",
          "kind": "test"
        },
        {
          "path": "types/chrome/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "matthewkimber",
        "otiai10",
        "sreimer15",
        "MatCarlson",
        "ekinsol",
        "tregagnon",
        "echoabstract",
        "spasma",
        "bdbai",
        "pokutuna",
        "JasonXian",
        "usertim",
        "idan315",
        "nicolas377",
        "idosal"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "changereq",
      "reviewer": "fregante",
      "date": "2023-02-08T07:59:45.000Z"
    }
  ],
  "mainBotCommentID": 1224099420,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/2a1797e4bbab0b709be586cf5223fe36c5959d27/checks?check_suite_id=7944575178"
}

[typescript-bot]

🔔 @matthewkimber @otiai10 @sreimer15 @matcarlson @ekinsol @tregagnon @EchoAbstract @spasma @bdbai @pokutuna @JasonXian @userTim @idan315 @nicolas377 @idosal — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@nickmccurdy The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[typescript-bot]

@nickmccurdy The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[typescript-bot]

@nickmccurdy The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[nickserv]

"target": "es6" doesn't seem to be working but I'm not sure why.

Error: 2> ../chrome/node_modules/@puppeteer/replay/lib/main.d.ts(442,5): error TS18028: Private identifiers are only available when targeting ECMAScript 2015 and higher.
Error: 2> ../chrome/node_modules/@puppeteer/replay/lib/main.d.ts(469,5): error TS18028: Private identifiers are only available when targeting ECMAScript 2015 and higher.
Error: 2> ../chrome/node_modules/@puppeteer/replay/lib/main.d.ts(499,5): error TS18028: Private identifiers are only available when targeting ECMAScript 2015 and higher.

[nickserv]

I'd appreciate help with the build errors.

[nickserv]

Taking another look, and the errors seem to be unrelated. Anything we can do to unblock this please?

[JasonXian]

Hey @nickmccurdy, I played around with different tsconfig options but couldn't seem to solve the issue either. I agree that updating the target to es6 should fix the puppeteer errors but it seems to just generates other errors as well.

For now, instead of importing Step and UserFlow for the argument types, it might be simpler to use any for now. I'd assume any downstream use cases would be passing in a properly typed argument from the types in the original library anyways, meaning there would still be some safety.

This isn't an ideal solution, but I don't think this build system issue is worth being blocked on in the meanwhile.

[fregante]

I'm not a fan of adding 1MB-plus dependency to a type package. I think this should be dropped. I think that if someone needs those types they can install it independently, even if this d.ts explicitly mentions import type {Step, UserFlow} from '@puppeteer/replay'

If that's not acceptable, how about vendoring replay’s d.ts instead? https://unpkg.com/browse/@puppeteer/[email protected]/lib/main.d.ts

[typescript-bot]

@nickmccurdy One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

[typescript-bot]

@nickmccurdy I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Mar 10th (in a week) if the issues aren't addressed.

[typescript-bot]

@nickmccurdy To keep things tidy, we have to close PRs that aren't mergeable and don't have activity in the last month. No worries, though — please open a new PR if you'd like to continue with this change. Thank you!