-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed MDPalette definition. #4479
Conversation
angular-material/angular-material.d.ts to author(@mtraynham). could you review this PR? check list
|
@robertbaker Palettes use simple strings here: But the code accepts an array or if string splits and converts it to an array: Ultimately, these properties get deleted from the palette, so they are only used at creation of the palette and not present in retrieval: |
Changed it. |
LGTM thanks @robertbaker |
@mtraynham thanks! |
https://github.com/mapbox/mapbox-gl-js/releases/tag/v0.39.0⚠️ Breaking changes GeolocateControl breaking changes [DefinitelyTyped#4479](mapbox/mapbox-gl-js#4479) The option watchPosition has been replaced with trackUserLocation The camera operation has changed from jumpTo (not animated) to fitBounds (animated). An effect of this is the map pitch is no longer reset, although the bearing is still reset to 0. The accuracy of the geolocation provided by the device is used to set the view (previously it was fixed at zoom level 17). The maxZoom can be controlled via the new fitBoundsOptions option (defaults to 15).
The values should be a string array and contrastStrongLightColors should be contrastLightColors