Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python3 migration issue #1287 #1371

Merged
merged 3 commits into from
Jul 16, 2019

Conversation

alles-klar
Copy link
Contributor

Related to #1287

During the python3 migration 'product_grade_b' was accidentally renamed to 'product_grade_'. This PR reverts the renaming.

This PR may break current installation which are based on the dev branch (python3) but makes the current branch compatible with installations which are based on the master branch.


Note: DefectDojo is now on Python3 and Django 2.2.1 Please submit your pull requests to the 'dev' branch as the 'legacy-python2.7' branch is only for bug fixes. Any new features submitted to the legacy branch will be ignored and closed.

When submitting a pull request, please make sure you have completed the following checklist:

  • Your code is flake8 compliant
  • If this is a new feature and not a bug fix, you've included the proper documentation in the ReadTheDocs documentation folder. https://github.com/DefectDojo/Documentation/tree/master/docs or provide feature documentation in the PR.
  • Model changes must include the necessary migrations in the dojo/dd_migrations folder.
  • Add applicable tests to the unit tests.

Renaming product_grade_ to product_grade_b again
(on behalf of DB Systel GmbH)
@devGregA
Copy link
Contributor

@alles-klar This is great catch, but I'm worried it may have some issues with installs currently running. Let me work through the use case then I'll merge.

@devGregA devGregA merged commit f15536e into DefectDojo:dev Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants