Allow plugin/controller/src/webotsFolder/dist to be usable by Webots by copying DeepBlueSim.jar into that folder so it can be used as a controller. #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by copying DeepBlueSim.jar into that folder so it can be used as a controller. This is used by the new tests project. See tests/README.md for more info.
Closed
CoolSpy3
requested changes
Jul 4, 2024
tests/README.md
Outdated
Comment on lines
1
to
4
| This project tests DeepBlueSim. It uses the DeepBlueSim plugin and contains tests that refer to | ||
| Webots worlds in `../plugin/controller/src/webotFolder/dist/worlds`. That makes it easier to debug | ||
| those worlds and the various DeepBlueSim Webots PROTOs. Note: the contents of *this* project's | ||
| `Webots` folder are ignored. |
There was a problem hiding this comment.
Two questions:
- Why are we including the test worlds in
controller? Given that this plugin extractscontroller/webotsFolder/distto whatever project its installed to, wouldn't this unnecessarily clutter users' worlds folder when they may only need one or two worlds (especially if this project grows to have a lot of tests). - Is this project going to replace
exampleor:example:systemTest? If not, what distinguishes the tests that will go in each of them?
There was a problem hiding this comment.
- I'm planning to either put the more test-oriented worlds in a subdir or only include the example-oriented worlds in the zip file that is used to create the Webots folder. Do you have a preference?
- The
testsproject is for maintainers to create system level tests of DeepBlueSim, including the various protos, mediators, etc. Theexampleproject (and possibly a futurelib199exampleproject) is for users to refer to or use as a starting point for their own projects. We don't needDBSExampleTestin the tests project since it is identical toSystemTestin the example project. I only put it intestsbecause I wanted to make sure that thetestsproject worked properly with multiple test classes loading multiple worlds.
There was a problem hiding this comment.
- What I might do is separate the worlds into a
worlds/examplesdirectory and aworlds/testsdirectory. That way it's more explicit what the purpose of each is (andWebots/worldscan stay fairly clean). - Sounds good! Does that also mean that
testswill ultimately end up includinglib199as well in order to test lib199 integration in-depth, or will that remain confined tolib199example?
There was a problem hiding this comment.
- Just created issue
plugin/controller/src/webotsFolder/dist/worldsneeds to be reorganized #87 to cover the proposed reorg. testswould include tests that uselib199as well as tests that don't.lib199examplewould contain only a test of a lib199 example world.
Co-authored-by: CoolSpy3 <[email protected]>
Co-authored-by: CoolSpy3 <[email protected]>
CoolSpy3
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used by the new tests project. See tests/README.md for more info.