Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] Fix vscode after command line changes. #402

Merged
merged 1 commit into from
May 20, 2020

Conversation

ejgallego
Copy link
Collaborator

The PR #289 broke the vscode plugin.

We do a hotfix for now, but the mode still remains broken if using
from the dev tree [for example with dune exec -- code].

This is quite inconvenient, for now lambdapi must be fully installed
as to be used from vscode.

The PR Deducteam#289 broke the vscode plugin.

We do a hotfix for now, but the mode still remains broken if using
from the dev tree [for example with `dune exec -- code`].

This is quite inconvenient, for now lambdapi must be fully installed
as to be used from vscode.
@ejgallego
Copy link
Collaborator Author

ejgallego commented May 20, 2020

Note @fblanqui @vycastor I have confirmed the mode works in full fine, provided the caveats above.

@fblanqui
Copy link
Member

@gabrielhdt, the problem that @ejgallego mentions (running vscode with the dev version), isn't also the case with emacs?

@fblanqui fblanqui merged commit 9f298d1 into Deducteam:master May 20, 2020
@ejgallego ejgallego deleted the vscode+fix_after_289 branch May 20, 2020 11:50
@gabrielhdt
Copy link
Member

gabrielhdt commented May 20, 2020

@gabrielhdt, the problem that @ejgallego mentions (running vscode with the dev version), isn't also the case with emacs?

As things are now, it is not easily possible to run the emacs mode with a development version of lambdapi, because the lsp server fetches the binary in the usual path. So there is no "breaking" problem, but the situation is not the happiest either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants