Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not allow underscores in assume tactic #1171

Merged
merged 6 commits into from
Jan 9, 2025

Conversation

fblanqui
Copy link
Member

@fblanqui fblanqui commented Jan 2, 2025

  • tactic: does not allow _ in assume
  • sig_state, scope: fix comments

lambdapi-stdlib <= 1.1.0 is not compatible with this change. The master branch of lambdapi-stdlib is compatible with this change (since fe8c1758d469df1c1eabe0a09690603791e819c2 on 31/12/24).

@fblanqui
Copy link
Member Author

fblanqui commented Jan 2, 2025

@NotBad4U @melanie-taprogge : Is this change a problem for you?

@melanie-taprogge
Copy link

@NotBad4U @melanie-taprogge : Is this change a problem for you?

It will not be an issue for me!

@NotBad4U
Copy link
Member

NotBad4U commented Jan 3, 2025

Yes, it breaks things on my side. I convert Alethe's ID name, such as t1.t2, into t1_t2.
I plan to use the {|i|} syntax in the future because SMT-LIB is more permissive than Lambdapi for identifiers.
So, that will not impact me in the future, but at this time, yes, it breaks stuff on my side.

But I do not understand why you want to refuse snake case syntax with assume.
What are you trying to do?

@fblanqui
Copy link
Member Author

fblanqui commented Jan 3, 2025

Hi Alessio. I don't understand your remark. The change is not about forbidding names with underscores but underscore itself which has a special meaning and is not implemented currently anyway.

@fblanqui
Copy link
Member Author

fblanqui commented Jan 3, 2025

@AntineaOgg : is this change a problem for you?

@NotBad4U
Copy link
Member

NotBad4U commented Jan 3, 2025

Hi Alessio. I don't understand your remark. The change is not about forbidding names with underscores but underscore itself which has a special meaning and is not implemented currently anyway.

Oh! Sorry, the comment of the PR misled me. I might have a few _ in some proof when I just want to ignore the name of a variable when I read the proof goal. But I can fix this quickly.

@AntineaOgg
Copy link

AntineaOgg commented Jan 6, 2025

@AntineaOgg : is this change a problem for you?

Hello, I don't think it will cause troubles for us.

@fblanqui fblanqui merged commit 3d1786b into Deducteam:master Jan 9, 2025
11 checks passed
@fblanqui fblanqui deleted the anonymous branch January 9, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants