Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sg 458 support for any user dataloader using dataset registry #547

Merged
merged 7 commits into from
Dec 11, 2022
Merged

Feature/sg 458 support for any user dataloader using dataset registry #547

merged 7 commits into from
Dec 11, 2022

Conversation

shaydeci
Copy link
Contributor

@shaydeci shaydeci commented Dec 6, 2022

  • Added support for launching recipes when only user has only the dataset class (i.e torch.Dataset).
  • Registry + factory added for datasets.
  • Example: launching MNIST training using the Mnist dataset alone (no DataLoader implementation).

@dagshub
Copy link

dagshub bot commented Dec 6, 2022

Join the discussion on DagsHub!

@shaydeci shaydeci marked this pull request as ready for review December 6, 2022 12:29
@shaydeci shaydeci requested a review from ofrimasad as a code owner December 6, 2022 12:29
ofrimasad
ofrimasad approved these changes Dec 11, 2022
View reviewed changes
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaydeci shaydeci merged commit beecf0d into master Dec 11, 2022
@shaydeci shaydeci deleted the feature/SG-458_support_for_any_user_dataloader branch December 11, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofrimasad ofrimasad ofrimasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaydeci @ofrimasad