Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added import of quantized modules so they get registered #542

Merged
merged 8 commits into from
Dec 19, 2022
Merged

Added import of quantized modules so they get registered #542

merged 8 commits into from
Dec 19, 2022

Conversation

spsancti
Copy link
Contributor

@spsancti spsancti commented Dec 5, 2022

No description provided.

@dagshub
Copy link

dagshub bot commented Dec 5, 2022

Join the discussion on DagsHub!

shaydeci
shaydeci approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shaydeci
shaydeci suggested changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

**Sorry for the approve before.

We need to talk this over, since PyTorch quantization is an optional installation.

ofrimasad
ofrimasad reviewed Dec 19, 2022
View reviewed changes
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment

src/super_gradients/modules/__init__.py Outdated Show resolved Hide resolved
ofrimasad
ofrimasad approved these changes Dec 19, 2022
View reviewed changes
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spsancti spsancti merged commit c455a52 into master Dec 19, 2022
@spsancti spsancti deleted the fix/quant_modules_register branch December 19, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaydeci shaydeci shaydeci approved these changes

@ofrimasad ofrimasad ofrimasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spsancti @ofrimasad @shaydeci