Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sg 431 check classes #531

Merged
merged 16 commits into from
Dec 19, 2022
Merged

Feature/sg 431 check classes #531

merged 16 commits into from
Dec 19, 2022

Conversation

BloodAxe
Copy link
Contributor

@BloodAxe BloodAxe commented Dec 1, 2022

@dagshub
Copy link

dagshub bot commented Dec 1, 2022

@BloodAxe BloodAxe marked this pull request as ready for review December 1, 2022 07:52
@BloodAxe BloodAxe requested a review from Louis-Dupont December 1, 2022 07:52
ofrimasad
ofrimasad previously approved these changes Dec 18, 2022
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... just a minor question/comment

# Conflicts:
#	tests/deci_core_unit_test_suite_runner.py
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofrimasad ofrimasad merged commit 713e66d into master Dec 19, 2022
@ofrimasad ofrimasad deleted the feature/SG-431-check-classes branch December 19, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants