Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the ability to download and import external code for models fro… #420

Merged
merged 11 commits into from
Oct 11, 2022

Conversation

ofrimasad
Copy link
Collaborator

…m the deci-lab

fixed a bug in all_architectures.py (model names were missing or changed)

…m the deci-lab

fixed a bug in all_architectures.py (model names were missing or changed)
@dagshub
Copy link

dagshub bot commented Oct 9, 2022

shaydeci
shaydeci previously approved these changes Oct 11, 2022
Copy link
Contributor

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just check that when we pip install this works, then LGTM.

I will also add to the backlog adding an integration tests as another part of the test plan for sg, that tests this mechanism.

Copy link
Contributor

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ofrimasad ofrimasad merged commit a73f9df into master Oct 11, 2022
@ofrimasad ofrimasad deleted the feature/SG-341_support_external_code branch October 11, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants