Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize SG dependencies #1946

Merged
merged 9 commits into from
Apr 9, 2024
Merged

Optimize SG dependencies #1946

merged 9 commits into from
Apr 9, 2024

Conversation

BloodAxe
Copy link
Contributor

@BloodAxe BloodAxe commented Apr 2, 2024

  1. Sphinx & Coverage dependencies moved to requirements.dev.txt
  2. Removed protobuf
  3. Removed numpy dependency as it will come from pytorch automatically and at this point <1.23 should not be relevant as we got rid of all numpy deprecation warnings
  4. Removed loose omegaconf requirement since it will come from hydra-core anyway
  5. Lift up onnx & onnxruntime versions (Can't remove since we have ModelConversionCallback that uses it)

@BloodAxe
Copy link
Contributor Author

BloodAxe commented Apr 8, 2024

A setuptools 67 was released in January 2023 which is eternity ago .
Can't we somehow exclude only affected version and not the whole two ears of releases?

ofrimasad
ofrimasad previously approved these changes Apr 9, 2024
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofrimasad ofrimasad merged commit 66919c2 into master Apr 9, 2024
6 checks passed
@ofrimasad ofrimasad deleted the feature/SG-000-optimize-deps branch April 9, 2024 11:31
@HanClinto HanClinto mentioned this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants