Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DistributedSamplerWrapper to automatically wrap non-dist samplers in cases we use dist mode #1856

Merged
merged 11 commits into from
Feb 26, 2024

Conversation

NatanBagrov
Copy link
Contributor

@NatanBagrov NatanBagrov commented Feb 22, 2024

This feature allows to wrap a non-distributed sampler and use it in a distributed setting. The wrapping happens automatically under-the-hood in case use is running DDP-mode and passed a non-distributed sampler.

Copy link
Contributor

@BloodAxe BloodAxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofrimasad ofrimasad merged commit 5727c28 into master Feb 26, 2024
9 checks passed
@ofrimasad ofrimasad deleted the feature/SG-000_distributed_sampler_wrapper branch February 26, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants