Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dice and BinaryDice metrics #174

Merged
merged 8 commits into from
May 2, 2022
Merged

Conversation

lkdci
Copy link
Contributor

@lkdci lkdci commented Apr 17, 2022

Added Dice and binary Dice metrics, by implementing _dice_from_confmat similar format as _jaccard_from_confmat torchmetrics implementation.

  • Added new metrics to MetricsFactory
  • Created new _preprocess_segmentation_inputs to prevent duplicate code in all segmentation metrics.
  • IoU now inherits from torchmetrics.JaccardIndex instead of torchmetrics.IoU which is no longer supported in torchmetrics 0.8.0.

@dagshub
Copy link

dagshub bot commented Apr 17, 2022

Copy link
Contributor

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline

@lkdci
Copy link
Contributor Author

lkdci commented Apr 19, 2022

Added AbstractMetricsArgsPrepFn and PreprocessSegmentationMetricsArgs as preprocess inputs callable function to be called on the metrics update.

…nto feature/ALG-391_dice_metrics

� Conflicts:
�	src/super_gradients/training/metrics/segmentation_metrics.py
@lkdci lkdci requested a review from shaydeci April 19, 2022 13:47
Copy link
Contributor

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lkdci lkdci merged commit 018bd0c into master May 2, 2022
@lkdci lkdci deleted the feature/ALG-391_dice_metrics branch May 2, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants