Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sg 1144 new export in quantization #1511

Merged
merged 6 commits into from
Oct 9, 2023

Conversation

BloodAxe
Copy link
Contributor

@BloodAxe BloodAxe commented Oct 9, 2023

This PR adds support to export YoloNAS/PPYoloE/YoloX models (That implements ExportableObjectDetectionModel) while using PTQ/QAT models.
Tested both on YoloNAS-S

Side note:
Currently we export model with preprocessing=False (Because we calibrated model using validation dataloader that already performed normalization) and postprocessing=True because users interested in end-to-end model.
However, maybe it make sense to introduce export_params section to give users mode control on export process (Choose max number of detections, batch/flat format, TRT or ONNX nms)

Copy link
Contributor

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit 3c342bb into master Oct 9, 2023
3 checks passed
@BloodAxe BloodAxe deleted the feature/SG-1144-new-export-in-quantization branch October 9, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants