Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLFM-3938 Create a code-loading utility in DeciClient #1393

Merged
merged 5 commits into from
Aug 21, 2023

Conversation

roikoren755
Copy link
Contributor

No description provided.

Copy link
Contributor

@Louis-Dupont Louis-Dupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor notes, but other than that looks good.
I am just wondering, what was the motivation?

src/super_gradients/common/plugins/deci_client.py Outdated Show resolved Hide resolved
src/super_gradients/common/plugins/deci_client.py Outdated Show resolved Hide resolved
@roikoren755
Copy link
Contributor Author

Minor notes, but other than that looks good. I am just wondering, what was the motivation?

We're working on an MVP that involves instantiating SG models, possibly with additional code, but one that will come from a different location than what is currently used in the client. I want to make this refactor, to have a re-usable piece of code to be able to use the additional code in other places too.

Copy link
Contributor

@Louis-Dupont Louis-Dupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roikoren755 roikoren755 merged commit 1680783 into master Aug 21, 2023
@roikoren755 roikoren755 deleted the feature/plfm-3938_code_loading_utility branch August 21, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants