-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segformer swi signed #1361
Merged
Merged
Segformer swi signed #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yael-Baron
requested review from
shaydeci,
ofrimasad,
BloodAxe and
Louis-Dupont
as code owners
August 10, 2023 07:51
Closed
Yael-Baron
force-pushed
the
Segformer_SWI_signed
branch
from
August 10, 2023 08:05
27198e6
to
958e5c2
Compare
Yael-Baron
force-pushed
the
Segformer_SWI_signed
branch
from
August 10, 2023 08:19
958e5c2
to
b9d3e75
Compare
BloodAxe
reviewed
Aug 11, 2023
BloodAxe
reviewed
Aug 11, 2023
BloodAxe
reviewed
Aug 11, 2023
LGTM overall. Please fix minor docstring issues and we can merge. Great work! |
Yael-Baron
force-pushed
the
Segformer_SWI_signed
branch
from
August 15, 2023 11:42
f7cc3dc
to
6e8a1be
Compare
Louis-Dupont
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following Segformer SWI #1292 PR but now signed.