Geometric figure annotator #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ools into zone-annotator
vlad-nn
requested changes
Sep 30, 2024
degirum_tools/__init__.py
Outdated
| subparser = subparsers.add_parser( | ||
| "line_annotator", | ||
| description="Launch interactive utility for geometric figure annotation in images", | ||
| help="launch interactive utility for geometric figure annotation in images", |
There was a problem hiding this comment.
Description and help strings for all three subparsers are the same - is it intent?
degirum_tools/figure_annotator.py
Outdated
| self.root.protocol("WM_DELETE_WINDOW", self.on_close) | ||
|
|
||
| # Set window icon | ||
| self.icon_image = ImageTk.PhotoImage(file="assets/logo.png") |
There was a problem hiding this comment.
How this file will appear in wheel installation?
If you really need it, you do this:
- Include it into the wheel installation. For example, into assets subdir of root package install dir.
- Construct full path to this file using the path of the current source file as a bas
vlad-nn
reviewed
Oct 1, 2024
degirum_tools/figure_annotator.py
Outdated
| @@ -483,7 +484,9 @@ def __init__( | |||
| self.root.protocol("WM_DELETE_WINDOW", self.on_close) | |||
|
|
|||
| # Set window icon | |||
| self.icon_image = ImageTk.PhotoImage(file="assets/logo.png") | |||
| self.icon_image = ImageTk.PhotoImage( | |||
| file=str(Path(__file__).parent.parent) + "/assets/logo.png" | |||
There was a problem hiding this comment.
It looks like .parent.parent should be just .parent. Otherwise, I get this error:
FileNotFoundError: [Errno 2] No such file or directory: 'C:\\ProgramData\\miniconda3\\Lib\\site-packages\\assets\\logo.png'
vlad-nn
reviewed
Oct 1, 2024
pyproject.toml
Outdated
| @@ -1,5 +1,5 @@ | |||
| [tool.mypy] | |||
| files = "degirum_tools,test" | |||
| files = "degirum_tools,test,assets" | |||
There was a problem hiding this comment.
You added it to wrong place. This is the list of files to be analyzed by mypy
vlad-nn
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.