This repository has been archived by the owner on Aug 24, 2023. It is now read-only.
refactor(packages): move to a single root package.json with turbo pipelines
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuxingloh
changed the title
package.json with turbo pipelines
✅ Deploy Preview for defimetachain ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
fuxingloh
force-pushed
the
fuxingloh/sticky
branch
from
f6afa1e to
9e8b0ec
Compare
fuxingloh
force-pushed
the
fuxingloh/sticky
branch
from
3502ee5 to
0107148
Compare
|
Docker image for defich/metachain is ready! Built with commit 648f810
|
Codecov Report
@@ Coverage Diff @@
## main #42 +/- ##
=====================================
Coverage 3.79% 3.79%
=====================================
Files 10 10
Lines 1711 1711
=====================================
Hits 65 65
Misses 1646 1646 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fuxingloh
requested review from
surangap,
DieHard073055 and
canonbrother
as code owners
canonbrother
approved these changes
Aug 31, 2022
| @@ -1,10 +1,10 @@ | |||
| { | |||
| "name": "@defichain/metachain-docs", | |||
| "name": "@defimetachain/docs", | |||
| "version": "0.0.0", | |||
There was a problem hiding this comment.
Should this be higher than 0.0.0?
I am not really familiar with the software versioning used in cake. Do you have a link to the software versioning doc used in cake?
There was a problem hiding this comment.
We don't have this documented yet, I'm working on the release model for this repo soon.
https://github.com/JellyfishSDK/jellyfish/blob/main/CONTRIBUTING.md#publishing
The TLDR is it will follow very closely to what was done at Jellyfish, where the release and the version are determined by the release drafter and annotated on release since we're doing trunk-based development.
It's related to this PR #47 where everything else is heavily automated, we just focus on pushing implementation and testing it.
This was referenced Sep 6, 2022
fuxingloh
added a commit
that referenced
this pull request
Sep 14, 2022
#### What this PR does / why we need it: Refactor and move `ts-tests` into mono-repo style packages to allow separation of context and downstream usability. This is the continuation of #42 `@defimetachain/testcontainers` Provides easy to use and test lightweight, throwaway instances of MetaChain provisioned automatically in a Docker container. `MetaChainContainer` and `StartedMetaChainContainer` follows the convention defined in [testcontainers/testcontainers-node](https://github.com/testcontainers/testcontainers-node) ```ts let container: StartedMetaChainContainer; let rpc: ethers.providers.JsonRpcProvider; beforeEach(async () => { container = await new MetaChainContainer().start(); }); afterEach(async () => { await container.stop(); }); it('should createBlock', async function () { await container.createBlock(); expect(await rpc.getBlockNumber()).toStrictEqual(1); }); ``` #### Which issue(s) does this PR fixes?: <!-- (Optional) Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Fixes #78 #### Additional comments?: The current implementation in `ts-tests` isn't yet migrated to use the new standard and convention defined here. That should be done as part of #79.
canonbrother
pushed a commit
that referenced
this pull request
Sep 28, 2022
#### What this PR does / why we need it: Refactor and move `ts-tests` into mono-repo style packages to allow separation of context and downstream usability. This is the continuation of #42 `@defimetachain/testcontainers` Provides easy to use and test lightweight, throwaway instances of MetaChain provisioned automatically in a Docker container. `MetaChainContainer` and `StartedMetaChainContainer` follows the convention defined in [testcontainers/testcontainers-node](https://github.com/testcontainers/testcontainers-node) ```ts let container: StartedMetaChainContainer; let rpc: ethers.providers.JsonRpcProvider; beforeEach(async () => { container = await new MetaChainContainer().start(); }); afterEach(async () => { await container.stop(); }); it('should createBlock', async function () { await container.createBlock(); expect(await rpc.getBlockNumber()).toStrictEqual(1); }); ``` #### Which issue(s) does this PR fixes?: <!-- (Optional) Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Fixes #78 #### Additional comments?: The current implementation in `ts-tests` isn't yet migrated to use the new standard and convention defined here. That should be done as part of #79.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Move docs into
packages/*and refactor node projects to use@birthdayresearch/sticky. Move to a single rootpackage.jsonwith turbo pipelines. Configure to use@birthdayresearch/*. (Mainly to utilizesticky-turbo-jest)This is the first of many PR to improve the Developer QOL for testing and developing on metachain.