Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignore validates with #702

Closed
wants to merge 2 commits into from
Closed

Fix ignore validates with #702

wants to merge 2 commits into from

Conversation

etlund
Copy link

@etlund etlund commented May 4, 2017

It appears there was a regression with ignoring validates_with. I've updated the test and reimplemented the fix from 89b429b.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.664% when pulling 2fdbeec on etlund:fix-ignore-validates-with into a0eed80 on DavyJonesLocker:4-2-stable.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.664% when pulling 2fdbeec on etlund:fix-ignore-validates-with into a0eed80 on DavyJonesLocker:4-2-stable.

@coveralls
Copy link

coveralls commented May 4, 2017

Coverage Status

Coverage remained the same at 99.664% when pulling 2fdbeec on etlund:fix-ignore-validates-with into a0eed80 on DavyJonesLocker:4-2-stable.

@tagliala
Copy link
Contributor

tagliala commented May 4, 2017

@etlund thanks for reporting this.

The offending commit is: 863616b and... I'm the author! 😞
😁 🎉

Problem is that I'm using return attr_hash instead of next attr_hash, which properly returns a value from a block

I'm going to fix this in the master branch. Please keep using your fork if you are interested in the 4.2 version, I will not backport the fix to 4-2-stable branch

Regards

@tagliala tagliala closed this May 4, 2017
@tagliala tagliala added this to the 9.3.1 milestone May 4, 2017
tagliala added a commit that referenced this pull request May 4, 2017
Fixes a regression introduced in 863616b

Close: #702
@tagliala
Copy link
Contributor

tagliala commented May 4, 2017

Thanks again. Version 9.3.1 released.

This is the commit: 47b96c1, if you want to backport that to 4-2-stable branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants