Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$response must be check for NULL value #12

Closed
egorsmkv opened this issue May 31, 2017 · 6 comments · Fixed by #17
Closed

$response must be check for NULL value #12

egorsmkv opened this issue May 31, 2017 · 6 comments · Fixed by #17
Labels
enhancement
Milestone
v0.1.3

Comments

@egorsmkv
Copy link

https://github.com/DavidePastore/ipinfo/blob/master/src/DavidePastore/Ipinfo/Ipinfo.php#L202
@DavidePastore DavidePastore added this to the v0.1.3 milestone Jul 5, 2017
@DavidePastore
Copy link
Owner

Hi @egorsmkv . Thanks for your suggestion. I'll try to fix it ASAP but if you already fixed it, you could create a PR. 🍨

@egorsmkv
Copy link
Author

egorsmkv commented Jul 5, 2017

@DavidePastore Sorry, but I don't fixed it.

@DavidePastore DavidePastore mentioned this issue Jul 13, 2017
Merged
@DavidePastore
Copy link
Owner

@egorsmkv Can you please check if #17 solves your issue? Thanks

@egorsmkv
Copy link
Author

@DavidePastore Having looked at the code, I think that the problem is solved.

DavidePastore added a commit that referenced this issue Jul 13, 2017
@DavidePastore
Add a null check for response
4b41f7b 
Closes #12 .
@DavidePastore
Copy link
Owner

@egorsmkv Thanks for your feedback. Just released v0.1.3 version with this fix and more.

@egorsmkv
Copy link
Author

egorsmkv commented Jul 13, 2017 •
edited
Loading

@DavidePastore your welcome. I will update my software later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v0.1.3
Development

Successfully merging a pull request may close this issue.

Response null check DavidePastore/ipinfo
2 participants
@DavidePastore @egorsmkv