Small program fixes #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug when you try to use port number ranges like "80,1000-1050". The user input is checked for the right-syntax, but saving the rule to the firewall is not correct. When the rule is loaded again, the given range ist lost, like "80,0" or a complete empty field.
Index error in port range compare.
There was the new instance still running as a zombie.
DavidXanatos
approved these changes
Oct 11, 2020
DavidXanatos
approved these changes
Oct 11, 2020
DavidXanatos
approved these changes
Oct 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first pull request, I hope it is OK.
First fix for input tcp or udp port ranges.
Second fix for comparing port ranges.
Third fix for closing a zombie instance of privatewin10.exe