fix: #453 param parser

packages/analytics-utils/package.json

@@ -26,6 +26,7 @@
   "unpkg": "dist/analytics-utils.umd.js",
   "sideEffects": false,
   "scripts": {
+    "test": "uvu tests -r esm",
     "start": "npm run sync && concurrently 'npm:watch:dev' 'npm:copy' 'npm:serve'",
     "serve": "servor dist index.html 8081 --reload --browse",
     "copy": "watchlist examples -- npm run sync",
@@ -43,8 +44,10 @@
   "devDependencies": {
     "concurrently": "^6.1.0",
     "microbundle": "^0.13.0",
+    "esm": "^3.2.25",
     "servor": "^4.0.2",
     "typescript": "^4.2.3",
+    "uvu": "^0.5.1",
     "watchlist": "^0.2.3"
   },
   "dependencies": {

packages/analytics-utils/src/paramsParse.js

@@ -41,7 +41,9 @@ function getParamsAsObject(query) {
     var v = decodeUri(temp[2])
     if (k.substring(k.length - 2) === '[]') {
       k = k.substring(0, k.length - 2);
-      (params[k] || (params[k] = [])).push(v)
+      var arrVal = params[k] || (params[k] = [])
+      params[k] = Array.isArray(arrVal) ? arrVal : []
+      params[k].push(v)
     } else {
       params[k] = (v === '') ? true : v
     }

packages/analytics-utils/tests/paramParse.test.js

@@ -1,28 +1,45 @@
-import test from 'ava'
-import {parseParam} from '../dist/paramsParse'
+import { test } from 'uvu'
+import * as assert from 'uvu/assert'
+import { paramsParse } from '../src/paramsParse'
 
-test('test simple params', t => {
+function toPlainObject(obj) {
+  return JSON.parse(JSON.stringify(obj))
+}
+
+function _paramsParse(url) {
+  return toPlainObject(paramsParse(url))
+}
+
+test('test simple params', () => {
   const url = 'http://localhost:3000/?hi=there&wow=lol'
-  const parsed = parseParam(url)
-  t.deepEqual(parsed, {
+  const parsed = _paramsParse(url)
+  assert.equal(parsed, {
     hi: 'there',
     wow: 'lol',
   })
 })
 
-test('test boolean params', t => {
+test('test boolean params', () => {
   const url = 'http://localhost:3000/?hi&no=false'
-  const parsed = parseParam(url)
-  t.deepEqual(parsed, {
+  const parsed = _paramsParse(url)
+  assert.equal(parsed, {
     hi: true,
     no: 'false',
   })
 })
 
-test('test utm params', t => {
+test('Duplicate param keys', () => {
+  const url = 'http://localhost:3000/?foo=&foo[]='
+  const parsed = _paramsParse(url)
+  assert.equal(parsed, {
+    foo: [''],
+  })
+})
+
+test('test utm params', () => {
   const url = 'http://localhost:3000/http://glocal.dev/?utm_source=the_source&utm_medium=camp%20med&utm_term=Bought%20keyword&utm_content=Funny%20Text&utm_campaign=400kpromo'
-  const parsed = parseParam(url)
-  t.deepEqual(parsed, {
+  const parsed = _paramsParse(url)
+  assert.equal(parsed, {
     utm_campaign: '400kpromo',
     utm_content: 'Funny Text',
     utm_medium: 'camp med',
@@ -31,12 +48,12 @@ test('test utm params', t => {
   })
 })
 
-test('test deeply nested url values', t => {
+test('test deeply nested url values', () => {
   const url =
     'http://localhost:3000/?Target=Offer&Method=findAll&filters[has_goals_enabled][TRUE]=1&filters[status]=active&filters[otherthing]&filters[wow]arr[]=yaz&filters[wow]arr[]=naz&filters[wow]arr[]=[other]&fields[]=id&fields[]=name&fields[]=default_goal_name&yes'
 
-  const parsed = parseParam(url)
-  t.deepEqual(parsed, {
+  const parsed = _paramsParse(url)
+  assert.equal(parsed, {
     Target: 'Offer',
     Method: 'findAll',
     fields: ['id', 'name', 'default_goal_name'],
@@ -49,3 +66,5 @@ test('test deeply nested url values', t => {
     },
   })
 })
+
+test.run()