Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion - Change Save settings to Save options to make it more consistent #74

Closed
Sopor opened this issue Dec 3, 2020 · 2 comments · Fixed by #98
Closed

Suggestion - Change Save settings to Save options to make it more consistent #74

Sopor opened this issue Dec 3, 2020 · 2 comments · Fixed by #98
Assignees
Labels
fixed Fixed but pending release
Milestone

Comments

@Sopor
Copy link

Sopor commented Dec 3, 2020

No big deal but it could be a bit confusing when you use Options in the main window and in the title of the window, but to save it i have to do that on a button called Save settings.

I would suggest you to change that button to Save options to make it more consistent.

It would also be nice if you could add a close button, because when i press the Save settings all the buttons gets grayed out. There is the small X in the upper right corner, but i still believe there should be a real close button :)

image

@DavidMoore DavidMoore added this to the 3.0.4 milestone Aug 18, 2023
@DavidMoore DavidMoore added the fixed Fixed but pending release label Aug 18, 2023
@DavidMoore DavidMoore self-assigned this Aug 18, 2023
@DavidMoore
Copy link
Owner

Fixed in 3.0.4

@Sopor
Copy link
Author

Sopor commented Aug 19, 2023

If i now open options both OK and Cancel buttons are grayed out, so i can't press Cancel if i want to leave.

Cancel shouldn't be grayed out.

image

DavidMoore added a commit that referenced this issue Aug 21, 2023
@DavidMoore DavidMoore linked a pull request Aug 21, 2023 that will close this issue
DavidMoore added a commit that referenced this issue Aug 21, 2023
* Fixing options quirks #74 #97

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Fixed but pending release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants