This repository has been archived by the owner on Sep 12, 2023. It is now read-only.
Added the capability to load a save file as a command line argument. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Now you don't need to load the game and issue the restore command to load a file. Everything else still works as one would think. I these changes are only going to effect the curses version for now. I do not have a proper enviroment setup to test out dos. Example: frotz file.zblorb -R save.qzl
| @@ -1,3 +1,13 @@ | |||
| Summary of changes between Frotz 2.44 and Frotz 2.45: | |||
There was a problem hiding this comment.
This should probably be changed. I wasn't sure what to put here.
|
This is going to need a lot of work. You used strcpy(), on user-supplied text. This is something that's a common source of exploits. Supplying a filename for a file that does not exist crashes the VM. I'm not sure I feel safe about what you're doing with f_setup.tmp_save_name. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there may be a few things that will need to be adjusted before this gets merged. These changes only take effect for the curses version. While dos and the sdl variants of these functions should not be broken.