Skip to content

Commit

Permalink
dmaengine: Revert "dmaengine: shdma: Fix runtime PM imbalance on error"
Browse files Browse the repository at this point in the history
This reverts commit 455896c ("dmaengine: shdma: Fix runtime PM
imbalance on error") as the patch wrongly reduced the count on error and
did not bail out. So drop the count by reverting the patch .

Signed-off-by: Vinod Koul <[email protected]>
  • Loading branch information
vinodkoul committed Mar 10, 2022
1 parent 60c10db commit d143f93
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/dma/sh/shdma-base.c
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,8 @@ static dma_cookie_t shdma_tx_submit(struct dma_async_tx_descriptor *tx)
ret = pm_runtime_get(schan->dev);

spin_unlock_irq(&schan->chan_lock);
if (ret < 0) {
if (ret < 0)
dev_err(schan->dev, "%s(): GET = %d\n", __func__, ret);
pm_runtime_put(schan->dev);
}

pm_runtime_barrier(schan->dev);

Expand Down

0 comments on commit d143f93

Please sign in to comment.