Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add APP_ENV #662

Merged
merged 3 commits into from
Oct 9, 2020
Merged

Add APP_ENV #662

merged 3 commits into from
Oct 9, 2020

Conversation

joelvh
Copy link
Contributor

@joelvh joelvh commented Jul 9, 2020

APP_ENV is becoming the "preferred" environment variable in various frameworks and scenarios as a more generic way of specifying an environment that may optionally diverge from the typical development and production names.

Some examples of adopting APP_ENV:

etagwerker
etagwerker approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joelvh Looks good, thanks! 🌮

@etagwerker etagwerker merged commit 661fe7e into DatabaseCleaner:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etagwerker etagwerker etagwerker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joelvh @etagwerker