Rails 4 2 11 3 upgrade #117
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pretty difficult to write an ActiveRecord 5 spec when the project is running ActiveRecord 3. DatabaseCleaner::ActiveRecord::Base#exclusion_condition wasn't previously tested anyways. ¯\_(ツ)_/¯
…pendency Remove undeclared active_support dependency. Fixes: #611
…com/hank-spokeo/database_cleaner into hank-spokeo-fix-ar-internal-metadata-truncation
Implemented alternative proposed by @olleolleolle: https://github.com/DatabaseCleaner/database_cleaner/pull/588/files#r373334472
…apter Fix and deprecate Ohm adapter
Currently, the following code doesn't work:
```ruby
DatabaseCleaner[:mongo].strategy = :truncation
RSpec.configure do |config|
config.around do |example|
DatabaseCleaner.cleaning do
example.run
end
end
end
```
The causes are:
1. `DatabaseCleaner::ORMAutodetector` doesn't consider `:mongo` option
2. `DatabaseCleaner::Mongo::Truncation` doesn't respond to `#cleaning`
…ate its default setting.
So that it recommends a more equivalent alternative.
…_model [v1.99] Deprecate :connection and :model in favor of :db
…etion_deprecation [v1.99] Rename truncation to deletion deprecations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe should update bundler as well