[SDK-v2] Fix TypeSet tests and Re-record cassettes #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix typo from cases to case * Do not persist state changes when modifying bad rule case * Update default rule case notifications * align default rule case notification recipients when rule case tracked in terraform configuration * clear default rule case notification recipients when rule case removed from terraform configuration * Remove broken tests It is not possible to use both ImportState: True and Check * Revert "Remove broken tests" This reverts commit fed89bf. * Reapply test changes, re-record * Lint Co-authored-by: Alexandre Trufanow <[email protected]> Co-authored-by: Thomas Hervé <[email protected]>
Don't use removed metric
* add dashboard_json resource * refactor and use client exported request methods * lint and move helper functions to util * lint * handle diffs on computed fields * normalize json string * add tests and refactor * update go client * lint * update tests and lint * apply code review requested changes * apply code review suggestions and re-record cassettes * generate resource docs * fmt
skarimo
changed the title
skarimo
changed the title
therve
approved these changes
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does several things: