-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated ExistsFunc usage #805
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
45742b1
to
f20ce40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the migration of exists into read looks pretty clean to me 💯
Sorry, the conflicts are likely me adding descriptions to the top level of the resources. Let me know if you want a hand with resolving those
f20ce40
to
72df1d1
Compare
NP haha, it wouldn't have happened if go's formatting didn't force alignement of values 😡 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!!
Merging, we'll deal with the silence test in a different PR |
cf https://www.terraform.io/docs/extend/guides/v2-upgrade-guide.html#deprecation-of-helper-schema-existsfunc
This deprecation is is SDK v2, but the alternative works just fine with our SDK version