Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated ExistsFunc usage #805

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Remove deprecated ExistsFunc usage #805

merged 2 commits into from
Jan 5, 2021

Conversation

zippolyte
Copy link
Contributor

cf https://www.terraform.io/docs/extend/guides/v2-upgrade-guide.html#deprecation-of-helper-schema-existsfunc
This deprecation is is SDK v2, but the alternative works just fine with our SDK version

@zippolyte zippolyte requested review from a team as code owners December 31, 2020 15:17
@zippolyte
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

nmuesch
nmuesch previously approved these changes Jan 4, 2021
Copy link
Contributor

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the migration of exists into read looks pretty clean to me 💯
Sorry, the conflicts are likely me adding descriptions to the top level of the resources. Let me know if you want a hand with resolving those

@zippolyte
Copy link
Contributor Author

zippolyte commented Jan 5, 2021

NP haha, it wouldn't have happened if go's formatting didn't force alignement of values 😡

Copy link
Contributor

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!!

@zippolyte
Copy link
Contributor Author

Merging, we'll deal with the silence test in a different PR

@zippolyte zippolyte merged commit 9d645f6 into master Jan 5, 2021
@zippolyte zippolyte deleted the hippo/rmexists branch January 5, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants