Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[monitor] Fix updating priorities. #804

Merged
merged 1 commit into from
Dec 31, 2020
Merged

[monitor] Fix updating priorities. #804

merged 1 commit into from
Dec 31, 2020

Conversation

phillip-dd
Copy link
Contributor

And adds a test to cover updating priorities.

cc @DataDog/monitor-app

@phillip-dd phillip-dd requested review from a team as code owners December 30, 2020 22:24
@phillip-dd phillip-dd force-pushed the pb/monitor-priority branch 4 times, most recently from 99d3459 to 0c91690 Compare December 31, 2020 00:15
zhengshizhao
zhengshizhao approved these changes Dec 31, 2020
View reviewed changes
Copy link
Contributor

@zhengshizhao zhengshizhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! thanks for fixing it!

@zippolyte
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@phillip-dd
Copy link
Contributor Author

Looks like silenced tests are failing:

=== FAIL: datadog TestAccDatadogMonitor_SilencedRemove (2.54s)
    testing.go:684: Step 1 error: Check failed: Check 4/4 error: datadog_monitor.foo: Attribute 'silenced.*' expected "-1", got "0"

=== FAIL: datadog TestAccDatadogMonitor_MuteUnmuteSpecificScopes
    testing.go:684: Step 1 error: After applying this step, the plan was not empty:

We fixed the issue around accepting 0s in the silenced - did some other behavior break here?

@zippolyte
Copy link
Contributor

I think it's not completely back to the behavior it had previously in the backend. IIUC, the backend also returned 0 in the response payload, but now returns null for the values where we put 0.

@zippolyte
Copy link
Contributor

Regardless, I think we can merge this as it's not related to the failure

@zippolyte zippolyte merged commit 3f89c92 into master Dec 31, 2020
@zippolyte zippolyte deleted the pb/monitor-priority branch December 31, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zippolyte zippolyte zippolyte approved these changes

@zhengshizhao zhengshizhao zhengshizhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phillip-dd @zippolyte @zhengshizhao