Validate enum values #794
Merged
Validate enum values #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therve
previously approved these changes
Dec 18, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
therve
requested changes
Dec 18, 2020
| @@ -5622,25 +5653,234 @@ func buildTerraformHostmapRequestStyle(datadogStyle datadogV1.HostMapWidgetDefin | |||
| } | |||
|
|
|||
| // Schema validation | |||
| func validateWidgetPalette(val interface{}, key string) (warns []string, errs []error) { | |||
| _, err := datadogV1.NewWidgetPaletteFromValue(val.(string)) | |||
| if err != nil { | |||
There was a problem hiding this comment.
With a little bit of elbow grease, I feel that we could define a wrapper function that you can directly assign to ValidateFunc. Seems non trivial. In the mean time, please inline the err check like if _, err := ..; err != nil
therve
previously approved these changes
Dec 28, 2020
datadog/validators.go
Outdated
| arg := reflect.ValueOf(val) | ||
| outs := reflect.ValueOf(newEnumFunc).Call([]reflect.Value{arg}) | ||
| err := outs[1].Interface() | ||
| if err != nil { |
There was a problem hiding this comment.
Please inline the condition withe previous line.
nmuesch
approved these changes
Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a validate function to all enum values for clear error messages and fail early to avoid sending bad payloads to API
Fixes #787