Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when setting synthetics status code assertion with regex #784

Merged
merged 2 commits into from
Dec 14, 2020
Merged

Fix error when setting synthetics status code assertion with regex #784

merged 2 commits into from
Dec 14, 2020

Conversation

zippolyte
Copy link
Contributor

@zippolyte zippolyte commented Dec 14, 2020 •
edited
Loading

Fixes #783

The target type is int only for operators is and isNot for the type statusCode, and string for operators matches and doesNotMatch

@zippolyte zippolyte requested review from a team as code owners December 14, 2020 12:02
romainberger
romainberger approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@romainberger romainberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM for Synthetics

@zippolyte
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zippolyte zippolyte merged commit 3b590e3 into master Dec 14, 2020
@zippolyte zippolyte deleted the hippo/fst branch December 14, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainberger romainberger romainberger approved these changes

@therve therve therve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when trying to use "matches" operator with "statusCode"
3 participants
@zippolyte @therve @romainberger